Give RAW captures their own output stream and gate reads on RAWENABLE - #29
Merged
Merged
Conversation
mikelangmayr
requested review from
astronomerdave,
prkrtg and
scizen9
as code owners
September 22, 2026 04:49
# Conflicts: # utils/fits_writer.cpp
prkrtg
reviewed
Sep 23, 2026
|
|
||
| // Raw is captured with the frame, so a buffer filled before RAWENABLE was set | ||
| // reports zero and raw_geometry() falls back to inferring from the config keys | ||
| if (this->frameinfo.bufrawblocks[index] == 0 || |
Contributor
There was a problem hiding this comment.
isn't this check in raw_geometry()?
Contributor
Author
There was a problem hiding this comment.
Yes, it was. raw_geometry() now sets a from_config flag in the one place that makes the decision, and read_raw warns off that instead of re-testing the buffer fields.
| constexpr int MODTYPE_ADM = 17; | ||
|
|
||
| // First backplane slot an AD or ADM module may occupy, which RAWSEL indexes from | ||
| constexpr int AD_SLOT_FIRST = 5; |
Contributor
There was a problem hiding this comment.
Does every AD module start at slot 5?
Contributor
There was a problem hiding this comment.
All ADCs are slots 5-8 only
Contributor
Author
There was a problem hiding this comment.
Slots 5-8 only, so the constant holds. Comment now states the full range rather than just the first slot.
astronomerdave
requested changes
Sep 23, 2026
Contributor
|
astronomerdave
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<base>_<frame>_raw.fits) and its own shared-memory segment (<segment>_raw) instead of colliding with the image or resizing its streamraw readrefuses whileRAWENABLEis 0, since the Archon captures raw alongside the frame and a controller with capture off is indistinguishable from one reporting nothingraw_geometry()decides in one place whether it fell back to the config keys, andraw readwarns off thatRAWSELverbatim, theMODn_TYPEof every slot it could address, and the four geometry keysRAWSEL: the manual documents four channels per slot over slots 5-8, the Archon GUI offers 72 selections which is eighteen per slot, and the two resolve differently on a mixed chassis16+: Unknownraw read